Open in StackBlitz

npm i https://pkg.pr.new/@typespec/http-client-csharp@11051

commit: 20925ae

No changes needing a change description found.

Review

Summary

The fix is well-scoped — ShouldOmitDiscriminatorParameterFromPublicConstructor only triggers for concrete back-compat discriminator bases (guarded by the IsAbstract logic), correctly excludes multi-level intermediate discriminators via the DiscriminatorValue is null check, and preserves the internal FullConstructor for serialization. Build is clean and the discriminator + back-compat test suites pass.

🔴 Blocking issue: derived models no longer compile

The fix removes the discriminator parameter from the base public constructor but does not update the base(...) call generated in derived models. Generating both the base and a derived model in this PR''s exact scenario produces:

public partial class BaseModel {
    public BaseModel(string baseProp) { ... }                                     // 1 param
    internal BaseModel(KindEnum kind, string baseProp, IDictionary<...> raw) {...} // 3 params
}

public partial class DerivedModel : BaseModel {
    public DerivedModel(string baseProp, int derivedProp)
        : base(KindEnum.One, baseProp)   // ❌ 2 args — matches NEITHER base ctor
}

base(KindEnum.One, baseProp) (2 args) matches neither the 1-param public nor the 3-param internal base constructor → compile error (CS1729).

This is exactly the issue''s real-world case: MetricAlertCriteria / MultiMetricCriteria have derived types, so the generated SDK would fail to compile. The new regression test doesn''t catch this because it inspects BaseModel in isolation and never builds/inspects a derived model''s base(...) call.

Recommendations

1. When the base public ctor drops the discriminator, the derived model''s initializer must call the matching base constructor (e.g. base(baseProp)) and set the discriminator value separately. The derived base(...) construction at ModelProvider.cs:982–1012 / GetExpressionForCtor needs to account for the omitted base discriminator parameter.
2. Add a regression test that generates a derived model of a concrete back-compat discriminator base and asserts (ideally compiles) that the emitted base(...) call matches an existing base constructor.

The intent and scoping are right, but as written it trades a public-API issue for a compilation break whenever the concrete discriminator base has derived types — the common case.

--generated by Copilot